Repository navigation
Conversation
…tls-pemfile This change makes the minimum changes necessary to adhere to the new response type from load_native_certs()
ethanhann
changed the title
drcaramelsyrup
added
the
dependencies
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses issue #772
rustls-pemfilewas used in two ways inpingora-rustls:rustls-native-certsThe explicit use was replaced by a newer version of
rustls-pki-typesthat included parsing functionality. This was a pretty simple change.Upgrading
rustls-native-certswas more complicated. Itsload_native_certs()function now returns an exhaustive list of errors. I preserved the existing behavior by returning on the first error. The bigger issue is thatpingora-rustlsexportsload_native_certs()which is technically a breaking change and should be noted in the release notes for the next version. Nothing else in the code base appears to rely on this re-export though.